Skip to content

Release workflow opens PR with changes #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Release workflow opens PR with changes #313

wants to merge 1 commit into from

Conversation

jiripetrlik
Copy link
Contributor

Issue link

Closes #290

What changes have been made

  • Release workflow opens PR with changes instead of direct push
  • All publish actions were moved to the end of workflow

@jiripetrlik jiripetrlik requested a review from sutaakar August 16, 2023 14:23
@jiripetrlik jiripetrlik force-pushed the 290-open-pr-for-releases branch from 242c244 to 01826b6 Compare August 17, 2023 12:06
@anishasthana anishasthana mentioned this pull request Aug 19, 2023
Merged
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sutaakar
Once this PR has been reviewed and has the lgtm label, please assign michaelclifford for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sutaakar
Copy link
Contributor

sutaakar commented Aug 21, 2023 •
edited
Loading

@jiripetrlik please check the failing PR check, there is some formatting issue

@anishasthana
Copy link
Contributor

I opened #315 which has the same changes as this PR. It also includes Jiri's specific commit (but with the formatting fix) -- we should close this PR out.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 21, 2023
@Srihari1192 Srihari1192 mentioned this pull request Aug 22, 2023
Merged
4 tasks
@anishasthana anishasthana removed the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
@jiripetrlik
Copy link
Contributor Author

Closing this PR because it was replaced by https://github.com/project-codeflare/codeflare-sdk/pull/315/commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sutaakar sutaakar sutaakar approved these changes

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford

Assignees

@sutaakar sutaakar

Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release workflow should open a PR with changes instead of direct push
4 participants
@jiripetrlik @sutaakar @anishasthana @openshift-merge-robot